Fix v-b-tooltip DOM node leak in grid components (#1093)#1099
Merged
Conversation
This reverts commit 6bf308c.
BVN's v-b-tooltip directive teleports a persistent DOM node to <body> for every bound element, causing quadratic growth in ResourceAvailability (scenes × mics) and linear growth in SceneDensityHeatmap and MicAllocations. Replace per-cell v-b-tooltip with a single shared BTooltip component per parent driven by @mouseenter/@Mouseleave — one DOM node regardless of row count, identical appearance and positioning via BVN's own floating-ui logic. A useHoverTooltip composable manages the shared target/text/visible state. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Keep feature branch implementation across all three mics components and the useHoverTooltip composable, discarding the revert that dev carried. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
The composable was called in script setup but never imported, causing ReferenceError at runtime. Added explicit import to all three components. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
…onents The merge conflict resolution had kept the old v-b-tooltip directive in the templates while only adding the useHoverTooltip script bindings. BVN's v-b-tooltip renders an inline node per bound element which, inside a CSS grid, occupies a grid cell and produces the staggered empty-column layout. Replaced all three remaining v-b-tooltip usages with the @mouseenter/@Mouseleave pattern that drives the shared BTooltip instance. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
v-b-tooltipinResourceAvailability.vue,SceneDensityHeatmap.vue, andMicAllocations.vuewith a single sharedBTooltipcomponent per parent, driven by@mouseenter/@mouseleavesrc/composables/useHoverTooltip.tsto manage the sharedtarget/text/visiblestateResourceAvailability(scenes × mics) and linear leaks in the other two components — DOM node count is now independent of data sizev-b-tooltipasBTooltipuses BVN's own floating-ui logicTest plan
npm run ci-lintcleannpm run typecheckclean🤖 Generated with Claude Code