ci/before-install: Attempt to improve Code Quality #1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Current shellcheck (http://ix.io/23fG) compared to proposed (http://ix.io/23fH) |
I'm forking this configuration in https://github.com/Kreyrock/Kreyrock so i rewrote it to what i consider better code quality excluding over-sanitization in this scenario. - Now this is compatible with POSIX shell and bash - Fixed Shellcheck excluding SC1090 since i don't know where the source for it is (probably in docker image to which we don't have an access?) - Unset variables since shell doesn't support `local var=value` - Added simplified error handling - Replaced echo with printf which is sligtly faster (https://unix.stackexchange.com/a/77564) and more reliable POSIX and cross-platform (https://unix.stackexchange.com/a/65819) - Rewrote if statements to be more readable - Replaced ${var} with $var since they are not needed and still require double quoting Signed-off-by: Jacob Hrbek <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm forking this configuration in https://github.com/Kreyrock/Kreyrock so i rewrote it to what i consider better code quality excluding over-sanitization in this scenario.
local var=valueSigned-off-by: Jacob Hrbek [email protected]