Polling fall back for Swift order confirmation #295
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's been reported that order confirmation logic is taking longer than it should to initiate. After some debugging, looks like it's specific to Swift orders, and arises from the
confirmedevent lagging to fire.Currently we use an initial fetch & WS to watch for the order confirmation and relay the
confirmedevent. I think it's possible that sometimes something like the following happens:This PR in turn adds polling in addition to the WS sub, so that in case something like the above happens, we can pick up the event without waiting for the full timeout.