feat: swift order type enabled #131
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LukasDeco
force-pushed
the
lukas/support-swift-123
branch
from
aa4d9e0 to
50ad9c2
Compare
jordy25519
reviewed
May 1, 2025
LukasDeco
force-pushed
the
lukas/support-swift-123
branch
from
9c8f574 to
d5e970b
Compare
LukasDeco
force-pushed
the
lukas/support-swift-123
branch
from
d5e970b to
bc1f39d
Compare
jordy25519
approved these changes
May 9, 2025
Collaborator
jordy25519
left a comment
jordy25519
left a comment
There was a problem hiding this comment.
code lgtm % couple nits
Comment on lines
+681
to
+683
| .swift_node | ||
| .clone() | ||
| .unwrap_or("https://master.swift.drift.trade".to_string()) |
Collaborator
There was a problem hiding this comment.
nit: better to set this as the default value at the args level not here
| }; | ||
| let incoming_msg = IncomingSignedMessage { | ||
| taker_authority: self.authority().to_string(), | ||
| signature: general_purpose::STANDARD.encode(signature), |
Collaborator
There was a problem hiding this comment.
i think this'll base64 it already
Suggested change
| signature: general_purpose::STANDARD.encode(signature), | |
| signature: signature.to_string(), |
| stop_loss_order_params: None, // TODO: add stop loss order params | ||
| }; | ||
|
|
||
| let signed_order_type = SignedOrderType::Authority(order); |
Collaborator
There was a problem hiding this comment.
need a TODO to support delegate signed message type here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #123