program: isolated position #1757
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
0xbigz
reviewed
Jul 31, 2025
wphan
reviewed
Jul 31, 2025
moosecat2
reviewed
Oct 7, 2025
programs/drift/src/state/user.rs
Outdated
Comment on lines
1091
to
1092
| /// The last base asset amount per lp the amm had | ||
| /// Used to settle the users lp position |
Member
There was a problem hiding this comment.
change field description probably a good idea
crispheaney
changed the title
wphan
reviewed
Oct 10, 2025
|
|
||
| pub fn exit_isolated_margin_bankruptcy(&mut self, perp_market_index: u16) -> DriftResult { | ||
| let perp_position = self.force_get_isolated_perp_position_mut(perp_market_index)?; | ||
| perp_position.position_flag &= !(PositionFlag::Bankrupt as u8); |
Member
There was a problem hiding this comment.
exit_cross_margin_bankruptcy also clears the BeingLiquidated flag on exit, should do that here?
wphan
reviewed
Oct 10, 2025
| /// precision: BASE_PRECISION | ||
| pub last_base_asset_amount_per_lp: i64, | ||
| /// precision: SPOT_BALANCE_PRECISION | ||
| pub isolated_position_scaled_balance: u64, |
Member
There was a problem hiding this comment.
is it worth taking over lp_shares and making this u128 too to avoid overflow issues like with spot?
Member
Author
There was a problem hiding this comment.
think its fine to make it as spot position since thats what normal usdc deposit uses
* program: add transfer isolated pos deposit into swift * cargo test
* program: start auto transfer * update * cargo fmt --
0xbigz
reviewed
Dec 2, 2025
programs/drift/src/state/user.rs
Outdated
| } | ||
|
|
||
| validate!( | ||
| calculation.meets_margin_requirement(), |
Member
There was a problem hiding this comment.
is this going to throw when cross margin under Initial and to_isolated_position = false?
Member
Author
There was a problem hiding this comment.
oops yeah gotta delete
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.