Patch floating labels #30
Conversation
There was a problem hiding this comment.
PR Overview
This PR introduces support for floating labels by adding a new slot in the VueTypeaheadBootstrap component and allowing custom input group classes while also updating the README with maintenance and repository migration information.
- Added a to enable custom label placement.
- Introduced the inputGroupClass prop for custom input group styling.
- Updated the README to reflect repository migration and maintenance changes.
Reviewed Changes
| File | Description |
|---|---|
| README.md | Updated the project status and maintenance information. |
| src/components/VueTypeaheadBootstrap.vue | Added floating label slot and custom input group class handling. |
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
Comments suppressed due to low confidence (1)
src/components/VueTypeaheadBootstrap.vue:137
- [nitpick] The prop name 'inputGroupClass' is very similar to the computed property 'inputGroupClasses', which may lead to confusion. Consider renaming the prop to something like 'customInputGroupClasses' to clearly indicate its purpose.
inputGroupClass: {
| if(this.inputGroupClass) return this.inputGroupClass | ||
| return this.size ? `input-group input-group-${this.size}` : 'input-group' |
There was a problem hiding this comment.
When inputGroupClass is provided, the default 'input-group' styling is completely bypassed. Consider merging inputGroupClass with the default classes to avoid potential layout issues, especially with floating labels.
| if(this.inputGroupClass) return this.inputGroupClass | |
| return this.size ? `input-group input-group-${this.size}` : 'input-group' | |
| const defaultClasses = this.size ? `input-group input-group-${this.size}` : 'input-group'; | |
| return this.inputGroupClass ? `${defaultClasses} ${this.inputGroupClass}` : defaultClasses; |
Copilot is powered by AI, so mistakes are possible. Review output carefully before use.
Hi @Volbeck, not sure if you are still interested in this PR but if so, could you please resolve the merge conflicts? |
Libriry allowes only using bootstrap input groups, it would be good to add opportunity of using floating labels