feat: add api for fetching provisioning info #26
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Introduced `get_provisioning_info` method in `btmesh-nrf-softdevice` driver. - Added logic to fetch and handle provisioning info in the driver library. - Updated `UnprovisionedConfiguration` struct with a Copy derive to enable getting default configuration. - Modified storage initialization to decouple loading from storage from init when driver is ran.
This commit only exposes the primary unicast address on the api. Other configuration information is still hidden and can contain sensitive information (keys).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
get_provisioning_infomethod inbtmesh-nrf-softdevicedriver.UnprovisionedConfigurationstruct with a Copy derive to enable getting default configuration.A review of this PR would be appreciated, specifically to check for any unsafe data sharing behavior or potential deadlocks.
Also, should the
get_provisioning_infofunction be part of theBluetoothMeshDrivertrait?