Conversation
794fad0 to
950ff6f
Compare
| "php": "~7.1", | ||
| "drupal/core": "~8.6", | ||
| "php": "~7.2", | ||
| "drupal/core": "^8.9 || ^9", |
There was a problem hiding this comment.
We should aim to keep the minimum required versions of PHP and core unchanged, this breaks backwards compatibility for existing projects. It should be possible to introduce Drupal 9 compatibility while still retaining full compatibility with 8.6 and PHP 7.1.
| "openeuropa/code-review": "~1.6", | ||
| "openeuropa/task-runner": "^1.0.0-beta6", |
There was a problem hiding this comment.
Let's not introduce the code review tool from OpenEuropa here. This is meant to be a project which is usable by the entire Drupal community. This organisation is owned by Jonathan Hedstrom, not by us. The OpenEuropa rules include checks which don't make sense for the wider Drupal community.
| services: | ||
| web: | ||
| image: fpfis/httpd-php-dev:7.2 | ||
| image: fpfis/httpd-php-dev:7.3 |
There was a problem hiding this comment.
Do you think it would be possible to have a test matrix that tests the full range of supported versions, all the way from Drupal 8.6 on PHP 7.1 to Drupal 9.1 on PHP 7.4? Travis supports this natively.
There was a problem hiding this comment.
@pfrenssen we have implemented the changes for the feedback asked, but it has been implemented in #8 but we dont have perissions to add commits so we forked. We don't have permissions, could you please check and merge if all is ok. Thanks in advance.
3 participants
No description provided.