Update CHANGELOG and fix mypy compatibility for curry.partial #2094
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sobolevn
reviewed
Apr 2, 2025
| @@ -0,0 +1,10 @@ | |||
| from returns.curry import partial | |||
There was a problem hiding this comment.
We use typesafety/ folder for typing tests.
You can find test_curry there.
| @@ -82,13 +82,15 @@ def _infer_constraints( | |||
| self._fallback.arg_names, | |||
| lambda index: checker.accept(exprs[index]), | |||
| ) | |||
|
|
|||
| arg_context = checker.argument_infer_context() | |||
There was a problem hiding this comment.
Sorry, how does this change fix the mypy compat? What even is the problem that we are fixing here?
AdrianAcala
force-pushed
the
1711-fix-mypy-1-6-1
branch
from
85a19c5 to
a06a7e9
Compare
- Added a bugfix entry in CHANGELOG for `curry.partial` compatibility with mypy 1.6.1+. - Modified `inference.py` to use a local variable for argument inference context. - Added mypy configuration file and a test for `partial` functionality in `test_partial.py`.
AdrianAcala
force-pushed
the
1711-fix-mypy-1-6-1
branch
from
a06a7e9 to
efa6e4e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
curry.partialcompatibility with mypy 1.6.1+.inference.pyto use a local variable for argument inference context.partialfunctionality intest_partial.py.I have made things!
Checklist
CHANGELOG.mdRelated issues
curry.partial#1711🙏 Please, if you or your company finds
dry-pythonvaluable, help us sustain the project by sponsoring it transparently on https://github.com/sponsors/dry-python. As a thank you, your profile/company logo will be added to our main README which receives hundreds of unique visitors per day.