Tests: Updating tests according to styling guide#214
Draft
wh33ly wants to merge 4 commits intodsccommunity:mainfrom
Draft
Tests: Updating tests according to styling guide#214wh33ly wants to merge 4 commits intodsccommunity:mainfrom
wh33ly wants to merge 4 commits intodsccommunity:mainfrom
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #214 +/- ##
===================================
- Coverage 89% 87% -2%
===================================
Files 7 7
Lines 987 987
Branches 0 1 +1
===================================
- Hits 881 868 -13
- Misses 106 118 +12
- Partials 0 1 +1 |
Member
|
Hi @wh33ly - I apologize for the long delay getting this reviewed. We've been moving all resources to a new CI/CD process that takes a fair amount of effort so I've been behind in my reviews. I'm also not certain why the tests are failing as it does not look like anything you've done. I'll close/open the PR to kick the AppVeyor again. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pull Request (PR) description
Updating tests according to styling guide
This Pull Request (PR) fixes the following issues
None
Task list
Entry should say what was changed, and how that affects users (if applicable).
and comment-based help.
This change is