Switch from built-in logger to logrus#3
Open
dvallant wants to merge 4 commits into
Open
Conversation
To increase the performance the regex pattern to find empty log messages was put outside the loop.
wozz
approved these changes
Jul 7, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey @dsouzajude,
In this PR logging is changed from built-in golang logging to logrus. With the new environment variable LOG_LEVEL the preferred log level can be set on start up.
Further, this PR adds some minor enhancements:
If you prefer I could create separate PRs for them :-)
Best wishes,
Dorian