Fix malformed packets in pack() causing challenge loop & buffer overread#17
Open
johnqherman wants to merge 1 commit intodsyomichev:masterfrom
Open
Fix malformed packets in pack() causing challenge loop & buffer overread#17johnqherman wants to merge 1 commit intodsyomichev:masterfrom
pack() causing challenge loop & buffer overread#17johnqherman wants to merge 1 commit intodsyomichev:masterfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
pack()appends a trailingFF FF FF FFto every packet by includingpreambleat both the start and end of theBuffer.concat()call. Per the Source Query Protocol, packets should only have theFF FF FF FFheader at the start.This causes the server to reject challenge responses as malformed and re-send the challenge. Since
solicit()only handlesa single challenge round, it treats the second challenge (9 bytes) as the actual query response and passes it to the
parser, which overreads the buffer.