Bugfix #3362 main_v12.2 seeps_pairs_nc#3363
Draft
JohnHalleyGotway wants to merge 1 commit intomain_v12.2from
Draft
Bugfix #3362 main_v12.2 seeps_pairs_nc#3363JohnHalleyGotway wants to merge 1 commit intomain_v12.2from
JohnHalleyGotway wants to merge 1 commit intomain_v12.2from
Conversation
…st timing info in the SEEPS output fields.
|
23 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Expected Differences
This PR provides as limited of a fix as possible for the
main_v12.2branch. This will modify the variables timing attributes in one Grid-Stat NetCDF matched pairs output file from SEEPS.Do these changes introduce new tools, command line arguments, or configuration file options? [No]
If yes, please describe:
Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]
If yes, please describe:
Pull Request Testing
Describe testing already performed for these changes:
Manually ran the updated unit test to confirm the expected change to the test output.
Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:
Review the modified Grid-Stat output file and confirm that the timing info is no longer reported as unixtime = 0.
Please find the code compiled on seneca in:
Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
None needed.
Do these changes include sufficient testing updates? [Yes]
Code changes modifies existing unit test output.
Will this PR result in changes to the MET test suite? [Yes]
If yes, describe the new output and/or changes to the existing output:
One Grid-Stat NetCDF matched pairs output file is modified.
Note
I found that NetCDF variable attribute differences are NOT currently flagged by the METplus diffing logic. Work to update the METplus diffing logic is in progress in the bugfix_MET_3362_diff_nc_var_att branch.
Will this PR result in changes to existing METplus Use Cases? [Maybe?]
If yes, create a new Update Truth METplus issue to describe them.
I'm not sure if any existing use cases generate Grid-Stat SEEPS output and write a NetCDF matched pairs output file. If so, then they'll be impacted.
Do these changes introduce new SonarQube findings? [Yes or No]
If yes, please describe:
Please complete this pull request review by [Monday, March 16, 2026].
Pull Request Checklist
See the METplus Workflow for details.
Select: Reviewer(s) and Development issue
Select: Milestone as the version that will include these changes
Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release