Skip to content

Bugfix #3362 main_v12.2 seeps_pairs_nc#3363

Draft
JohnHalleyGotway wants to merge 1 commit intomain_v12.2from
bugfix_3362_main_v12.2_seeps_pairs_nc
Draft

Bugfix #3362 main_v12.2 seeps_pairs_nc#3363
JohnHalleyGotway wants to merge 1 commit intomain_v12.2from
bugfix_3362_main_v12.2_seeps_pairs_nc

Conversation

@JohnHalleyGotway
Copy link
Collaborator

@JohnHalleyGotway JohnHalleyGotway commented Mar 12, 2026

Expected Differences

This PR provides as limited of a fix as possible for the main_v12.2 branch. This will modify the variables timing attributes in one Grid-Stat NetCDF matched pairs output file from SEEPS.

  • Do these changes introduce new tools, command line arguments, or configuration file options? [No]

    If yes, please describe:

  • Do these changes modify the structure of existing or add new output data types (e.g. statistic line types or NetCDF variables)? [No]

    If yes, please describe:

Pull Request Testing

  • Describe testing already performed for these changes:

    Manually ran the updated unit test to confirm the expected change to the test output.

  • Recommend testing for the reviewer(s) to perform, including the location of input datasets, and any additional instructions:

    Review the modified Grid-Stat output file and confirm that the timing info is no longer reported as unixtime = 0.

Please find the code compiled on seneca in:

/d1/projects/MET/MET_pull_requests/met-12.2.2/MET-bugfix_3362_main_v12.2_seeps_pairs_nc
  • Do these changes include sufficient documentation updates, ensuring that no errors or warnings exist in the build of the documentation? [Yes]
    None needed.

  • Do these changes include sufficient testing updates? [Yes]
    Code changes modifies existing unit test output.

  • Will this PR result in changes to the MET test suite? [Yes]

    If yes, describe the new output and/or changes to the existing output:

    One Grid-Stat NetCDF matched pairs output file is modified.

Note

I found that NetCDF variable attribute differences are NOT currently flagged by the METplus diffing logic. Work to update the METplus diffing logic is in progress in the bugfix_MET_3362_diff_nc_var_att branch.

  • Will this PR result in changes to existing METplus Use Cases? [Maybe?]

    If yes, create a new Update Truth METplus issue to describe them.
    I'm not sure if any existing use cases generate Grid-Stat SEEPS output and write a NetCDF matched pairs output file. If so, then they'll be impacted.

  • Do these changes introduce new SonarQube findings? [Yes or No]

    If yes, please describe:

  • Please complete this pull request review by [Monday, March 16, 2026].

Pull Request Checklist

See the METplus Workflow for details.

  • Review the source issue metadata (required labels, projects, and milestone).
  • Complete the PR definition above.
  • Ensure the PR title matches the feature or bugfix branch name.
  • Define the PR metadata, as permissions allow.
    Select: Reviewer(s) and Development issue
    Select: Milestone as the version that will include these changes
    Select: METplus-X.Y Support project for bugfix releases or MET-X.Y Development project for the next coordinated release
  • After submitting the PR, select the ⚙️ icon in the Development section of the right hand sidebar. Search for the issue that this PR will close and select it, if it is not already selected.
  • After the PR is approved, merge your changes. If permissions do not allow this, request that the reviewer do the merge.
  • Close the linked issue and delete your feature or bugfix branch from GitHub.

…st timing info in the SEEPS output fields.
@sonarqubecloud
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: 🔎 In review

Development

Successfully merging this pull request may close these issues.

Bugfix: Fix the timing information of the SEEPS data written to Grid-Stat NetCDF matched pairs output files

1 participant