[Feature] std::panic::Location support #291
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onlycs
changed the title
update with upstream
|
This is a solid change. I've started using it in a project of mine and it's working great. |
|
+1 |
|
Anything blocking the merge of this? It would be a great feature to have! |
|
Working for this one to be merged too, any plans ? 👀 |
|
I'm gonna resolve the merge conflicts at some point but this should be working on the latest version soon™ I have like, negative free time rn. |
|
this is up-to-date and ready. all tests completed successfully @dtolnay can this merge? |
tgrushka
added a commit
to dra11y/wherror
that referenced
this pull request
Jul 21, 2025
Implements automatic call site location capture for error types with &'static Location<'static> fields. Location fields are automatically populated when From trait conversions occur, enabling precise error location tracking without manual instrumentation. Features: - Auto-detection of Location<'static> fields in structs and enum variants - Optional #[location] attribute for explicit field marking - Automatic From impl generation with #[track_caller] - Support for both named and tuple enum variants - Location populated via Location::caller() during From conversion - No #[from] attribute required on location fields Based on dtolnay#291 by @onlycs (Angad Tendulkar) Closes dtolnay#142 - Support for tracing with std::panic::Location Co-authored-by: Angad Tendulkar <[email protected]>
tgrushka
added a commit
to dra11y/wherror
that referenced
this pull request
Jul 21, 2025
- Rebrand from thiserror to wherror across all packages - Add comprehensive README documentation for location feature - Update all imports and references throughout codebase - Add location support implementation with automatic call site capture - Include proper attribution to original thiserror and PR dtolnay#291 authors
|
This would be amazing to see merged <3 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #142