Feature win support - #11
Merged
Merged
Conversation
This is necessary because mecab is not easily buildable on windows 64bit
This was referenced Jan 26, 2023
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR brings Windows support to mecab_dart.
Features:
libmecab.dllin the exampleExplanation for separate .dll:
Windows support is a bit more involved than Linux because mecab is difficult to compile on windows for 64bit systems.
To compile on windows
nmakeis used and this has some issues on 64bit systems with the default sources. Following taku910/mecab#46 I included updated mecab sources to build on windows in thewindows/srcdirectory. Those can be build usingnmake -f Makefile.x64.msvc. The resultinglibmecab.dllthan needs to be included in the build. This can be done by modifying the CMakeLists of the application. The steps are detailed in the README.This procedure is not inline with how the other platforms build mecab, but I do not see a way around this.