Skip to content

Improve checks on tests (using logs) #276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
carlopi wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Improve checks on tests (using logs) #276

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion test/sql/logging/http_logging.test
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@ SELECT
request.url,
response.status,
response.reason,
FROM duckdb_logs_parsed('HTTP') WHERE response.status != 'ServiceUnavailable_503'
FROM duckdb_logs_parsed('HTTP') WHERE response.status != 'ServiceUnavailable_503' AND response.status != 'TooManyRequests_429'
----
HEAD https://github.com/duckdb/duckdb/raw/main/data/csv/customer.csv OK_200 OK
GET https://github.com/duckdb/duckdb/raw/main/data/csv/customer.csv PartialContent_206 Partial Content
Expand Down
28 changes: 15 additions & 13 deletions test/sql/storage/external_file_cache/external_file_cache_read_blob.test_slow
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,20 +6,22 @@ require parquet

require httpfs

statement ok
CALL enable_logging('HTTP');

# first read_blob should do 1 GET
query II
explain analyze from read_blob('https://blobs.duckdb.org/data/shakespeare.parquet');
----
analyzed_plan <REGEX>:.*GET: 1.*
statement ok
from read_blob('https://blobs.duckdb.org/data/shakespeare.parquet');

# second one should do 0
query II
explain analyze from read_blob('https://blobs.duckdb.org/data/shakespeare.parquet');
----
analyzed_plan <REGEX>:.*GET: 0.*
statement ok
from read_blob('https://blobs.duckdb.org/data/shakespeare.parquet');

statement ok
from 'https://blobs.duckdb.org/data/shakespeare.parquet';

# although the read was cached using read_blob, the parquet reader can read from cache
query II
explain analyze from 'https://blobs.duckdb.org/data/shakespeare.parquet';
query IIIII
FROM (FROM (FROM duckdb_logs_parsed('HTTP') WHERE response.status != 'ServiceUnavailable_503' AND response.status != 'TooManyRequests_429') SELECT count(*), sum(request.type == 'HEAD') head, sum(request.type == 'GET') get, sum(request.type == 'POST') post, sum(request.type == 'PUT') put GROUP BY context_id ORDER BY context_id);
----
analyzed_plan <REGEX>:.*GET: 0.*
2 1 1 0 0
1 1 0 0 0
1 1 0 0 0
Loading