[WIP] HTTPMetadataCache should also store OpenFileExtendedInfo #64
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tries. Then it should be easier to check any extended info in the future.'
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If there is extended info, options like "validate_external_cache" can be read from any thread.
This is WIP because the extended_info is still a shared pointer between the HTTPMetadataCache and HTTPFileHandle etc. It's still possible to have two handles reading from the same memory. The problem with that is what happens if the extended_options object becomes very big? (We will probably deal with that later then).
Eventually there may be extra options, one I can see is a "direct_get" option, which will translate to not executing a head request and executing a GET request. This will help with Lakehouse formats (i.e Iceberg) where we don't want to execute a HEAD request if we KNOW we are still going to execute a GET request.