-
Notifications
You must be signed in to change notification settings - Fork 31
Add code quality workflows: format and tidy #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
While this PR is ready, it's probably worth waiting a bit longer to first absorb the rest of the work. |
|
||
#### Misc | ||
format-check: | ||
python3 duckdb/scripts/format.py --all --check --directories extension/httpfs test |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can just move the extension code to src
like other extensions?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, moving to src
is right, I will do so post 1.3.2 given there are a bunch of in-flight PRs.
Also format code might need to take the paths from a Makefile variable instead of hardcoding, but that's minor.
I think this happens via the extension-ci-tools repo by default right? So this can also be closed? |
No, this needs to be added on a repo-by-repo basis, at the very least adding something like:
or equivalent (maybe changing branch names) |
No description provided.