-
Notifications
You must be signed in to change notification settings - Fork 32
Use curl as optional client v1.4 #96
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Tmonster
wants to merge
64
commits into
duckdb:v1.4-andium
Choose a base branch
from
Tmonster:use_curl_as_optional_client_v1.4
base: v1.4-andium
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Use curl as optional client v1.4 #96
Tmonster
wants to merge
64
commits into
duckdb:v1.4-andium
from
Tmonster:use_curl_as_optional_client_v1.4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t overwritten on the stack
…optional_client_v1.4
hannes
added a commit
to duckdb/duckdb
that referenced
this pull request
Aug 18, 2025
Yes this will fix my build errors at duckdb/duckdb-httpfs#96. This CI link has a passing build status https://github.com/duckdb/duckdb-httpfs/actions/runs/16991311944/job/48171130825 ~~[DO NOT MERGE]: I am testing to see if this is the correct fix with [this PR](duckdb/duckdb-httpfs#96) first. I am just updating the duckdb submodule pointer for the httpfs fork to the branch here. If those tests pass then I know what the correct fix is. (don't know how to trigger it otherwise yet)~~ This is prompted by this PR duckdb/duckdb-httpfs#96. Related [CI failure](https://github.com/duckdb/duckdb-httpfs/actions/runs/16932639981/job/47981684022?pr=96#step:26:597) Seems like the httplib has conflicts with the max() function. I've searched for other instances of `::max()` and `::min()` in httplib.hpp and didn't find any. It seems like the proper fix is to use `(std::numeric_limits<size_t>::max)()` as seen on line [96 of httplib.hpp](https://github.com/duckdb/duckdb/blob/1f0de28806a8915c8203dd060dad549f28f5539b/third_party/httplib/httplib.hpp#L96) and that did not fail the windows build
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow up to #86, except merging with v1.4-duckdb to see if CI resolves. Otherwise will need intervention on duckdb submodule pointer as well
Picking up #77 to merge #58 and add a way to optionally set the client_implementation.
This integrates AND #76, since they have some interactions that needed some care.
After duckdb/duckdb#18107 landed in duckdb/duckdb, and moving the duckdb submodule to a recent commit on v1.3-ossivalis, this PR allows to switch at runtime based on the newly added httpfs config option httpfs_client_implementation:
Please check original PR from @Tmonster that all relevant details: #58, this PR only adds a setting and resolve conflict with ongoing work.
Probably best path is cherry-picking commit back into original PR, or anyhow to be discussed on a side.