-
Notifications
You must be signed in to change notification settings - Fork 26
Attempt to resolve SSL_connect missing symbol problem #99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
CMakeLists.txt
Outdated
@@ -53,7 +57,8 @@ add_definitions(-DUI_EXTENSION_GIT_SHA="${UI_EXTENSION_GIT_SHA}") | |||
build_static_extension(${TARGET_NAME} ${EXTENSION_SOURCES}) | |||
build_loadable_extension(${TARGET_NAME} " " ${EXTENSION_SOURCES}) | |||
|
|||
target_link_libraries(${EXTENSION_NAME} OpenSSL::SSL OpenSSL::Crypto) | |||
target_link_libraries(ui_loadable_extension ${OPENSSL_LIBRARIES}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're not building the ui_loadable_extension
so we should remove this
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm. That's not true, because of the line above this: build_loadable_extension(${TARGET_NAME} " " ${EXTENSION_SOURCES})
.
And if I remove the line for target_link_libraries(ui_extension)
my setting of building and running the extension still succeeds.
removed unnecessary static libs directive.
Ok! Co-authored-by: Y. <[email protected]>
So I have additionally tried with both As discussed in the review, maybe I did misunderstand that
Example of running it after building with these changes:
|
This pull request modifies
CMakeLists.txt
based on comparison with the HTTPFS extension, to solve a building problem reported in issue #89