Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

remove binary_executor.patch #1959

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

remove binary_executor.patch #1959

wants to merge 1 commit into from

Conversation

e1arikawa
Copy link
Contributor

@e1arikawa e1arikawa commented Feb 19, 2025 •
edited
Loading

When running make apply_patches, binary_executor.patch fails.

$ make apply_patches
(find patches/duckdb/* -type f -name '*.patch' -print0 | xargs -0 cat | patch -p1 --forward -d submodules/duckdb) || true
patching file 'src/include/duckdb/common/vector_operations/binary_executor.hpp'
4 out of 7 hunks failed--saving rejects to 'src/include/duckdb/common/vector_operations/binary_executor.hpp.rej'
...

In DuckDB 1.2, modifications related to DUCKDB_SMALLER_BINARY have been applied to binary_executor.hpp.
Therefore, I think binary_executor.patch is unnecessary.

@e1arikawa e1arikawa force-pushed the feature/fix_binary_executor_patch branch from d7877b1 to d45a234 Compare February 22, 2025 12:10
@e1arikawa e1arikawa changed the title fix binary_executor.patch remove binary_executor.patch Feb 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@e1arikawa