Skip to content

Add AI entry point to search bar #5692

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 33 commits into from
Apr 24, 2025
Merged

Conversation

joshliebe
Copy link
Contributor

@joshliebe joshliebe commented Feb 26, 2025

Task/Issue URL: https://app.asana.com/0/488551667048375/1209499349481348

Description

  • Adds a Duck.ai entry point to the address bar
  • Adds animations between the focussed and unfocussed states
  • Adds a setting to enable/disable the entry point

Steps to test this PR

Default behavior

  • Check out this branch
  • Verify that the omnibar has the same behavior as current prod
  • The Duck.ai “Show in address bar” setting should not be visible

Entry point enabled

  • Point at the config linked in the task
  • Verify that the new tab has the entry point
  • Focus the address bar
  • Verify that the other buttons animate away and the entry point is visible
  • Search for something
  • Verify that the entry point is not visible
  • Focus the address bar
  • Verify that the entry point is visible

Setting disabled

  • Disable “Show in address bar” in settings
  • Verify that the entry point is no longer visible

UI changes

focussed_combined
input_combined
voice_search_combined
settings_combined


Copy link
Contributor Author

joshliebe commented Feb 26, 2025

This stack of pull requests is managed by Graphite. Learn more about stacking.

@joshliebe joshliebe force-pushed the feature/josh/ai-search-bar branch 2 times, most recently from 40094b0 to 06201f2 Compare March 11, 2025 02:02
@joshliebe joshliebe force-pushed the feature/josh/ai-search-bar branch from 6712219 to b50516d Compare April 9, 2025 00:03
@joshliebe joshliebe force-pushed the feature/josh/ai-search-bar branch from 55970a5 to 7b5ea06 Compare April 14, 2025 23:33
@joshliebe joshliebe marked this pull request as ready for review April 23, 2025 14:06
Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Discussed this offline

Copy link
Contributor

@malmstein malmstein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, just one nit

@joshliebe joshliebe merged commit 435c5af into develop Apr 24, 2025
8 checks passed
@joshliebe joshliebe deleted the feature/josh/ai-search-bar branch April 24, 2025 17:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants