adds hints trying to improve read performance #5798
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
12 tasks
This stack of pull requests is managed by Graphite. Learn more about stacking. |
7 tasks
CDRussell
changed the base branch from
feature/cristian/sync/align_recovery_with_connect_flow
to
graphite-base/5798
cmonfortep
force-pushed
the
feature/cristian/sync/improve_scan_accuracy
branch
from
835f50f to
b8253b8
Compare
cmonfortep
force-pushed
the
graphite-base/5798
branch
from
193b7ae to
978ce08
Compare
cmonfortep
changed the base branch from
graphite-base/5798
to
feature/cristian/sync/align_recovery_with_connect_flow
CDRussell
changed the base branch from
feature/cristian/sync/align_recovery_with_connect_flow
to
graphite-base/5798
CDRussell
reviewed
Mar 21, 2025
Comment on lines
+135
to
+137
| if (syncFeature.qrCodeScannerHints().isEnabled()) { | ||
| if (appBuildConfig.isInternalBuild()) { | ||
| beepManager = BeepManager(getActivity()) |
There was a problem hiding this comment.
want to switch the order of these two if statements?
appBuildConfig.isInternalBuild() is cheaper than syncFeature.qrCodeScannerHints().isEnabled() so would be good to check that first
also, can you get syncFeature.qrCodeScannerHints().isEnabled() off of the main thread?
| @@ -86,13 +98,22 @@ constructor( | |||
| ViewModelProvider(findViewTreeViewModelStoreOwner()!!, viewModelFactory)[SquareDecoratedBarcodeViewModel::class.java] | |||
| } | |||
|
|
|||
| private var beepManager: BeepManager? = null | |||
|
|
|||
| private val cameraSettings = CameraSettings().apply { | |||
There was a problem hiding this comment.
should this also be kill-switch’d ? (separate from qrCodeScannerHints)
It seems like an innocent no-brainer of a change, but you never know...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1209726713190993/f
Description
Adds some options trying to improve QR scan performance
Steps to test this PR
N/A just try scan QR codes
UI changes