Add support for scam protection

[CrisBarreiro]

Task/Issue URL: https://app.asana.com/0/0/1209879813659870

Description

Steps to test this PR

Feature 1

• Fresh install the app
• Using the app inspector, check that only phishing and malware datasets are present. Data needs to be downloaded, so it might take a few seconds to complete. The easiest way is to check the revisions table in malicious_sites db
• Open https://privacy-test-pages.site/security/badware/phishing.html and check it's blocked
• Open https://privacy-test-pages.site/security/badware/malware.html and check it's blocked
• Open https://privacy-test-pages.site/security/badware/scam.html and check it's not blocked

Feature 2

• Set @Toggle.DefaultValue(true) for scamProtection
• Fresh install the app
• Using the app inspector, check that phishing, malware and scam datasets are present. Data needs to be downloaded, so it might take a few seconds to complete. The easiest way is to check the revisions table in malicious_sites db
• Open https://privacy-test-pages.site/security/badware/phishing.html and check it's blocked
• Open https://privacy-test-pages.site/security/badware/malware.html and check it's blocked
• Open https://privacy-test-pages.site/security/badware/scam.html and check it's blocked
• Check m_malicious-site-protection_error-page-shown is fired with category=scam
• Accept risk and visit site
• Check m_malicious-site-protection_visit-site is fired with category=scam
• Click the omnibar icon
• Check privacy dashboard is shown normally
• Disable scamProtection under Feature Flag Inventory and restart the app
• Open https://privacy-test-pages.site/security/badware/scam.html and check it's not blocked

From #5857

Feature 1

• Fresh install the app
• Using the app inspector, check that only phishing and malware datasets are present. Data needs to be downloaded, so it might take a few seconds to complete. The easiest way is to check the revisions table in malicious_sites db
• Open https://privacy-test-pages.site/security/badware/phishing.html and check it's blocked
• Open https://privacy-test-pages.site/security/badware/malware.html and check it's blocked
• Open https://privacy-test-pages.site/security/badware/scam.html and check it's not blocked

Feature 2

• Without reinstalling the app, enable scamProtection under Feature Flag Inventory and restart the app
• Using the app inspector, check that phishing, malware and scam datasets are present. Data needs to be downloaded, so it might take a few seconds to complete. The easiest way is to check the revisions table in malicious_sites db
• Open https://privacy-test-pages.site/security/badware/scam.html and check it's blocked.
• Disable scamProtection under Feature Flag Inventory and restart the app
• Open https://privacy-test-pages.site/security/badware/scam.html and check it's not blocked

UI changes

---

• To see the specific tasks where the Asana app for GitHub is being used, see below:
  • https://app.asana.com/0/0/1209910424512874

[CrisBarreiro]

• Add support for scam protection #5853 : 2 dependent PRs (#5857 , #5964 ) 👈 (View in Graphite)
• develop

This stack of pull requests is managed by Graphite. Learn more about stacking.

[cmonfortep]

Just few NITs.

We need to rebase develop to get the changes introduced with the ANR fix. After that I will re-review and test this.

[cmonfortep]

I don't feel this generic method is the right place to put the feature flag check. Can we do it earlier?

[CrisBarreiro]

I moved it to a different place, but it's not super relevant, as #5857 deals with this in a different way

[cmonfortep]

NIT: I think it will be more readable (and easy to expand) if we move it as separate early checks

For example:

if (feed == SCAM && !maliciousSiteProtectionRCFeature.scamProtectionEnabled()) return@let Ignored

return@let Malicious(feed)

[cmonfortep]

LGTM 👍