Android: Add dismiss option to contextual onboarding #5866
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anikiki
changed the title
…longer needed. Removed the use of the skip button in the Privacy Pro CTA. Removed unused test related to removed pixel. Updated.
anikiki
force-pushed
the
feature/ana/android_add_dismiss_option_to_contextual_onboarding
branch
from
54048f1 to
73e8729
Compare
…ed to show the new tab when bubble dismissed.
nalcalag
reviewed
Apr 9, 2025
There was a problem hiding this comment.
@anikiki this looks great! 💯 I’ve suggested a couple of changes, feel free to correct me if any of my assumptions are off:
- When the 'Fire dialog' is dismissed, the expected behavior is to simply close it without showing the 'End dialog'. I’ve pointed out the part of the logic that might need to be removed.
- The new pixel should ideally be triggered from the
CtaViewModel, in line with how we handle other pixels. This helps keep the code consistent and clean.
Comment on lines
2818
to
2832
| fun onUserClickCtaDismissButton(cta: Cta) { | ||
| viewModelScope.launch { | ||
| onUserDismissedCta(cta) | ||
| if (cta is DaxBubbleCta) { | ||
| command.value = HideOnboardingDaxBubbleCta(cta) | ||
| pixel.fire(ONBOARDING_DAX_CTA_DISMISS_BUTTON, mapOf(PixelParameter.CTA_SHOWN to cta.ctaPixelParam)) | ||
| } else if (cta is OnboardingDaxDialogCta) { | ||
| command.value = HideOnboardingDaxDialog(cta) | ||
| pixel.fire(ONBOARDING_DAX_CTA_DISMISS_BUTTON, mapOf(PixelParameter.CTA_SHOWN to cta.ctaPixelParam)) | ||
| if (cta is OnboardingDaxDialogCta.DaxFireButtonCta) { | ||
| val updatedCta = ctaViewModel.getEndStaticDialogCta() | ||
| ctaViewState.value = currentCtaViewState().copy(cta = updatedCta) | ||
| } else if (cta is OnboardingDaxDialogCta.DaxTrackersBlockedCta) { | ||
| ctaViewModel.dismissPulseAnimation() | ||
| } |
There was a problem hiding this comment.
Pixel firing should be handled on the CtaViewModel. I would follow the same pattern as we already have for shown and ok pixels.
Comment on lines
2828
to
2829
| val updatedCta = ctaViewModel.getEndStaticDialogCta() | ||
| ctaViewState.value = currentCtaViewState().copy(cta = updatedCta) |
There was a problem hiding this comment.
This is no longer needed. The expected behavior when a user dismisses the fire dialog is simply to close it and not show the end dialog anymore.
There was a problem hiding this comment.
Good catch! Removed it 👍
anikiki
deleted the
feature/ana/android_add_dismiss_option_to_contextual_onboarding
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/488551667048375/1209734574040696/f
Description
Added a dismiss button to onboarding context and in-context Dax dialogs. The implementation includes:
ONBOARDING_DAX_CTA_DISMISS_BUTTONto track dismissalsSteps to test this PR
Onboarding DAX Dialogs
ctaparam and noatbparam) .UI changes (added a dismiss button, removed the skip buttons)