Skip to content
This repository has been archived by the owner on Feb 24, 2025. It is now read-only.

Add fireproofing option to Fire popover #2966

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

mallexxx
Copy link
Collaborator

Task/Issue URL: https://app.asana.com/0/1204517122485752/1205507100821092/f

Steps to test this PR:

  1. Open new tab, open Fire popover, validate there‘s no fireproofing option
  2. Open another tab, navigate to non-fireproofed website, validate there‘s fireproofing option
  3. Fireproof, validate the button changes its state to Remove fireproofing
  4. Open new tab, navigate to another website, open the popover
  5. Hit cmd+w to close the tab, validate the button state changes
  6. Hit cmd+w to get to the New Tab page, validate Fireproofing option disappears

Definition of Done:


Internal references:

Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant