This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Update to autofill DAU reporting for iOS credential provider extension #3763
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on-ios-daus # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
amddg44
changed the title
…on-ios-daus # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…on-ios-daus # Conflicts: # DuckDuckGo.xcodeproj/project.pbxproj # DuckDuckGo.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
graeme
approved these changes
Jan 27, 2025
…on-ios-daus # Conflicts: # DuckDuckGo-macOS.xcodeproj/project.pbxproj # DuckDuckGo-macOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
…on-ios-daus # Conflicts: # DuckDuckGo-macOS.xcodeproj/project.pbxproj # DuckDuckGo-macOS.xcodeproj/project.xcworkspace/xcshareddata/swiftpm/Package.resolved
amddg44
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 1, 2025
…sion events (#1177) Task/Issue URL: https://app.asana.com/0/1201462886803403/1208980858161408/f iOS PR: duckduckgo/iOS#3851 macOS PR: duckduckgo/macos-browser#3763 What kind of version bump will this require?: Minor **Description**: Update AutofillPixelReporter to support shared app group UserDefaults in order to count fill events from the iOS credential provider extension towards Autofill DAUs
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201462886803403/1208980858161408/f
Tech Design URL:
CC:
Description:
Minor update to support BSK change to AutofillPixelReporter
Steps to test this PR:
Regression testing to confirm there are no changes on macOS
main, reset Autofill Data via the debug menu if the app has already been used todaym.autofill.activeuseris firedDefinition of Done:
—
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation