Tab bar scrolling fixed #3793
Open
Tab bar scrolling fixed #3793
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomasstrba
commented
Jan 28, 2025
| @@ -703,7 +703,12 @@ extension TabBarViewController: TabCollectionViewModelDelegate { | |||
| updateEmptyTabArea() | |||
| hideTabPreview() | |||
| if tabMode == .overflow { | |||
| collectionView.scroll(to: IndexPath(item: index)) | |||
| let isLastItem = collectionView.numberOfItems(inSection: 0) == index + 1 | |||
There was a problem hiding this comment.
I tried a couple of different solutions and investigated why scroll(to: doesn't scroll to the item completely. Unfortunately, I haven't found a reason so decided to create this simple workaround to fix the most common problem
tomasstrba
requested review from
a team,
studiosutara and
graeme
and removed request for
a team and
studiosutara
graeme
approved these changes
Jan 29, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1201048563534612/1209257294295137/f
Description:
Scrolling to the new open tab fixed.
Steps to test this PR:
Optional: Repeat the test with a bunch of pinned tabs
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation