This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Malicious Site Protection - Optional clientSideHit parameter #3796
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-pixels-client-side-hit-optional
branch
from
23e6f06 to
93114a0
Compare
mallexxx
approved these changes
Jan 30, 2025
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-pixels-client-side-hit-optional
branch
from
93114a0 to
6a53bd8
Compare
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-ios-updates
branch
from
21b8492 to
abb942c
Compare
alessandroboron
force-pushed
the
alessandro/malicious-site-protection-pixels-client-side-hit-optional
branch
from
6a53bd8 to
048221a
Compare
alessandroboron
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Jan 31, 2025
) **Required**: Task/Issue URL: https://app.asana.com/0/1206329551987282/1209242004458518/f iOS PR: duckduckgo/iOS#3891 macOS PR: duckduckgo/macos-browser#3796 What kind of version bump will this require?: Minor **Description**: This PR makes `MaliciousSiteProtection.Event.errorPageShown` `clientSideHit` parameter optional. See dicussion in [AsanaTask](https://app.asana.com/0/1206329551987282/1209242004458518/f)
alessandroboron
merged commit 2fd8f8d
into
alessandro/malicious-site-protection-ios-updates
20 checks passed
alessandroboron
deleted the
alessandro/malicious-site-protection-pixels-client-side-hit-optional
branch
alessandroboron
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 4, 2025
) **Required**: Task/Issue URL: https://app.asana.com/0/1206329551987282/1209242004458518/f iOS PR: duckduckgo/iOS#3891 macOS PR: duckduckgo/macos-browser#3796 What kind of version bump will this require?: Minor **Description**: This PR makes `MaliciousSiteProtection.Event.errorPageShown` `clientSideHit` parameter optional. See dicussion in [AsanaTask](https://app.asana.com/0/1206329551987282/1209242004458518/f)
alessandroboron
added a commit
to duckduckgo/BrowserServicesKit
that referenced
this pull request
Feb 5, 2025
) **Required**: Task/Issue URL: https://app.asana.com/0/1206329551987282/1209242004458518/f iOS PR: duckduckgo/iOS#3891 macOS PR: duckduckgo/macos-browser#3796 What kind of version bump will this require?: Minor **Description**: This PR makes `MaliciousSiteProtection.Event.errorPageShown` `clientSideHit` parameter optional. See dicussion in [AsanaTask](https://app.asana.com/0/1206329551987282/1209242004458518/f)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206329551987282/1209242004458518/f
Description:
Update BSK Ref to version where clientSideHit pixel parameter is optional
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation