Implement VPN App Exclusions management view #3800
Conversation
…ego/vpn-app-exclusions-dialogue
…ego/vpn-app-exclusions-dialogue
|
| import PackageDescription | ||
|
|
||
| let package = Package( | ||
| name: "AppInfoRetriever", |
There was a problem hiding this comment.
Since I'm adding some code to retrieve information from 3rd party apps living in /Applications, I figured it would be good to modularize it into a Swift Package.
LocalPackages/AppInfoRetriever/Tests/AppInfoRetrieverTests/AppInfoTests.swift
Outdated
Show resolved
Hide resolved
| value > 0 ? String(value) : "None" | ||
| value > 0 ? String(value) : UserText.vpnNoExclusionsFoundText |
There was a problem hiding this comment.
One note on this, it didn't update automatically when I excluded an app, so it was telling me I had nothing excluded until I closed and re-opened the settings UI.
There was a problem hiding this comment.
Will try to get proper refresh fixed before merging this.
|
|
||
| } | ||
|
|
||
| public class AppInfoRetriever: AppInfoRetrieveing { |
There was a problem hiding this comment.
Neat – we could possibly reuse this for the data import feature, which does some app info lookup of its own but in a non-generic way.
There was a problem hiding this comment.
Only issue I had with this was that the string showing the number of excluded apps didn't refresh after changing my list of exclusions. Also, the apps I excluded sometimes had to be restarted for it to take effect, but this is nothing new. Otherwise it worked really well, no issues!
|
Addressed the refresh issue and no other feedback pending so I'll go ahead and merge. Thanks! |
Task/Issue URL: https://app.asana.com/0/0/1209150117333886/f
Description
Adds app exclusions management UI, effectively enabling app exclusions behind the feature flag.
Translations
Job is here.
Known limitations
Testing
Some basic testing expectations:
Test app exclusions work
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation