Update scheme names #3806
Open
Update scheme names #3806
+232
−339
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
samsymons
commented
Jan 31, 2025
| BlueprintIdentifier = "SyncUITests" | ||
| BuildableName = "SyncUITests" | ||
| BlueprintName = "SyncUITests" | ||
| ReferencedContainer = "container:LocalPackages/SyncUI-macOS"> |
There was a problem hiding this comment.
This was a regression from the SyncUI rename, sorry 😢 Xcode didn't surface this in any way whatsoever.
samsymons
commented
Jan 31, 2025
There was a problem hiding this comment.
Git has gotten confused here - we had some old schemes that referenced targets that have since been deleted, like DuckDuckGo Privacy Pro. All that happened here was I deleted these old schemes, and renamed the existing ones without otherwise modifying them.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1193060753475688/1209277496027580/f
Tech Design URL:
CC:
Description:
This PR updates scheme names to disambiguate them when combined into an XCWorkspace.
Here are the new scheme names, please feel free to request changes on any of these:
Please note that I haven't done anything with local package schemes etc., I've focused this PR on the targets that are found within the
DuckDuckGo-macOScontainer.Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation