This repository was archived by the owner on Feb 24, 2025. It is now read-only.
Duck Player Custom Error #3872
Closed
Duck Player Custom Error #3872
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mgurgel
force-pushed
the
mgurgel/duckplayer-custom-error
branch
from
ce91f9e to
1236215
Compare
mgurgel
commented
Feb 14, 2025
| isCustomErrorFeatureEnabled = | ||
| privacyConfigurationManager.privacyConfig.isSubfeatureEnabled(DuckPlayerSubfeature.customError) | ||
|
|
||
| // TODO: Check if this logic can be moved into privacyConfig |
There was a problem hiding this comment.
PrivacyConfigurationData has FeatureSettings = [String: Any] and SubfeatureSettings = String even though they are the same data type in the privacy config schema.
Is SubfeatureSettings just a stub that should be refactored to return [String: Any] like FeatureSettings, which would make the code block below much smaller?
Closed
6 tasks
|
Closed in favor of duckduckgo/apple-browsers#23 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Task/Issue URL: https://app.asana.com/0/1206594217596623/1209151829557390
Description:
Shows a custom error screen when Duck Player detects an error message in the YouTube embed
Optional E2E tests:
Check this to run the Personal Information Removal end to end tests. If updating CCF, or any PIR related code, tick this.
Steps to test this PR:
Definition of Done:
Internal references:
Pull Request Review Checklist
Software Engineering Expectations
Technical Design Template
Pull Request Documentation