Skip to content

Conversation

hanyutang-sandra
Copy link
Contributor

@hanyutang-sandra hanyutang-sandra commented Sep 16, 2025

Asana Task/Github Issue: https://app.asana.com/1/137249556945/task/1211289533034357?focus=true

Description

Toggle provisional push notification feature off
Prepared now in case it needs to be toggled off in an emergency that I’m not around

Feature change process:

  • I have added a schema to validate this feature change.
  • I have tested this change locally in all supported browsers.
  • This code for the config change is ready to merge.
  • This feature was covered by a tech design.

@hanyutang-sandra hanyutang-sandra requested review from daxtheduck and a team as code owners September 16, 2025 09:21
@hanyutang-sandra hanyutang-sandra added the DO NOT MERGE Don't merge this branch unless directed label Sep 16, 2025
@hanyutang-sandra hanyutang-sandra removed the request for review from jleandroperez September 16, 2025 09:21
github-actions bot pushed a commit that referenced this pull request Sep 16, 2025
Copy link

👋 Don't forget to add an individual reviewer (in addition to those auto-added), as this will create a task for them in Asana.

👉 Please mark this as DRAFT unless there's an intention to merge this immediately.
👉 Click "Merge when ready" if you're happy for this to be automatically merged once reviewed. (If not available, ensure you've signed in to DuckDuckGo oauth.)
👉 Don't forget to add schema changes to validate if you're adding/changing a feature.

Copy link

github-actions bot commented Sep 16, 2025

Generated file outputs:

Time updated: Tue, 16 Sep 2025 09:23:29 GMT

legacy
27 files identical
  • trackers-unprotected-temporary.txt
  • v3/android-config.json
  • v3/extension-brave-config.json
  • v3/extension-bravemv3-config.json
  • v3/extension-chrome-config.json
  • v3/extension-chromemv3-config.json
  • v3/extension-config.json
  • v3/extension-edg-config.json
  • v3/extension-edge-config.json
  • v3/extension-edgmv3-config.json
  • v3/extension-firefox-config.json
  • v3/extension-safarimv3-config.json
  • v3/macos-config.json
  • v3/windows-config.json
  • v4/android-config.json
  • v4/extension-brave-config.json
  • v4/extension-bravemv3-config.json
  • v4/extension-chrome-config.json
  • v4/extension-chromemv3-config.json
  • v4/extension-config.json
  • v4/extension-edg-config.json
  • v4/extension-edge-config.json
  • v4/extension-edgmv3-config.json
  • v4/extension-firefox-config.json
  • v4/extension-safarimv3-config.json
  • v4/macos-config.json
  • v4/windows-config.json

⚠️ File is identical

2 files changed
  • v3/ios-config.json
  • v4/ios-config.json
--- v4/ios-config.json (and 1 other files)
+++ v4/ios-config.json
@@ -102827,9 +102827,9 @@
                 "widgetReporting": {
                     "state": "disabled"
                 },
                 "inactivityNotification": {
-                    "state": "internal",
+                    "state": "disabled",
                     "description": "Local inactivity provisional notifications delivered to Notification Center.",
                     "targets": [
                         {
                             "localeLanguage": "en",
latest
13 files identical
  • v5/android-config.json
  • v5/extension-brave-config.json
  • v5/extension-bravemv3-config.json
  • v5/extension-chrome-config.json
  • v5/extension-chromemv3-config.json
  • v5/extension-config.json
  • v5/extension-edg-config.json
  • v5/extension-edge-config.json
  • v5/extension-edgmv3-config.json
  • v5/extension-firefox-config.json
  • v5/extension-safarimv3-config.json
  • v5/macos-config.json
  • v5/windows-config.json

⚠️ File is identical

v5/ios-config.json
--- v5/ios-config.json
+++ v5/ios-config.json
@@ -102827,9 +102827,9 @@
                 "widgetReporting": {
                     "state": "disabled"
                 },
                 "inactivityNotification": {
-                    "state": "internal",
+                    "state": "disabled",
                     "description": "Local inactivity provisional notifications delivered to Notification Center.",
                     "targets": [
                         {
                             "localeLanguage": "en",

Copy link

github-actions bot commented Sep 16, 2025

JSON approval analysis:

Time updated: Tue, 16 Sep 2025 09:23:34 GMT

legacy

❌ Manual Review Required

  • v3/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/iOSBrowserConfig/features/inactivityNotification/state (replace)
  • v4/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/iOSBrowserConfig/features/inactivityNotification/state (replace)
latest

❌ Manual Review Required

  • v5/ios-config.json (1 total changes)
    Disallowed paths that require review:
    • /features/iOSBrowserConfig/features/inactivityNotification/state (replace)

🎯 OVERALL APPROVAL STATUS

❌ MANUAL REVIEW REQUIRED

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
DO NOT MERGE Don't merge this branch unless directed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant