Reposition of plugin.setCaption() (#37)

The new Caption should show up immediately without waiting for its corresponding image to load. Otherwise it would be misleading watching(reading again) the old caption while waiting for the new image to load. Co-authored-by: TheCrazyProgrammer <[email protected]>
duncanmcdougall · Nov 30, 2020 · 8ae65a0 · 8ae65a0
1 parent af3b48c
commit 8ae65a0
Showing 1 changed file with 2 additions and 3 deletions.
diff --git a/jquery.lightbox.js b/jquery.lightbox.js
@@ -67,13 +67,12 @@
                 plugin.lightbox.fadeIn('fast').append('<span class="lightbox__loading"></span>');
 
                 var img = $('<img src="' + $(plugin.current).attr('href') + '" draggable="false">');
-
+                plugin.setCaption();
                 $(img).on('load', function () {
                     $('.lightbox__loading').remove();
                     plugin.lightbox.append(img);
                     plugin.image = $("img", plugin.lightbox).hide();
                     plugin.resizeImage();
-                    plugin.setCaption();
                 });
             },
 
@@ -213,4 +212,4 @@
         plugin.init(this);
     };
 
-})(jQuery);
+})(jQuery);