docs: try_files performance

[AlliBalliBaba]

Update to the docs with the most performant file_server setups (disabling file_server won't really gain any performance).

[dunglas]

I've not tried it, but something like that should work too (and is likely cleaner):

Suggested change

	route {
	@assets {
	path /assets/*
	}
	# everything behind /assets is handled by the file server
	handle @assets {
	root /root/to/your/app
	file_server
	}
	# everything that is not in /assets is handled by your index or worker PHP file
	rewrite index.php
	php {
	root /root/to/your/app # explicitly adding the root here allows for better caching
	}
	}
	route {
	@assets {
	path /assets/*
	}
	# Everything behind /assets is handled by the file server
	file_server @assets {
	root /root/to/your/app
	}
	# Everything that is not in /assets is handled by your index or worker PHP file
	php_server {
	try_files index.php
	file_server off
	}
	}

[AlliBalliBaba]

php_server { 
    root /go/src/app/testdata
    try_files index.php
    file_server off
}

seems like 1x file access still from somewhere

php_server {
	root /go/src/app/testdata
	try_files index.php {
		policy first_exist_fallback
	}
	file_server off
}

Even with explicit 'policy first_exist_fallback' this still does a file access

rewrite index.php
php {
	root /go/src/app/testdata
}

With a rewrite and php there is no file access:

[dunglas]

Ok, let's merge the change as-is then. That would be nice to find out what is causing this extra IO (and if we can prevent it).

[AlliBalliBaba]

Yeah we can wait and see if this can be prevented before merging the docs 👍

[AlliBalliBaba]

Turns out the file access comes from this glob. Tbh first globbing and then checking for explicit file existence just does the same thing twice. This could probably be significantly optimized, but you'd have to be careful about not breaking stuff (especially on windows).

[AlliBalliBaba]

I'll probably make a PR to Caddy to optimize this. Skipping glob() on files without wildcards will reduce the number of file operation by 1 in the case any file in try_files matches.

Still, using php instead of php_server removes the overhead of the Matcher, so this PR should be fine to merge as-is.

[dunglas]

Actually, maybe should we explain that in a separate php_server or even try_files section as it's not really related to file_server?

Also, we should update the Laravel page to use this config by default.

[AlliBalliBaba]

Yeah good idea! Probably makes sense to update the default Caddy stub in Octane as well.

[dunglas]

yes definitely, also API PLatform and Symfony Docker. It's on my todolist.