Suppress alpine allocation issue #1284
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The callback is just used when `WL_OUTPUT_NAME_SINCE_VERSION` is defined and so, this function should defined only then as well as it otherwise is flagged as being unused which breaks the build.
The current output is: ``` ==208== HEAP SUMMARY: ==208== in use at exit: 848,426 bytes in 8,621 blocks ==208== total heap usage: 89,284 allocs, 80,663 frees, 11,942,430 bytes allocated ==208== ==208== 3 bytes in 1 blocks are definitely lost in loss record 384 of 2,994 ==208== at 0x48A97C1: realloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==208== by 0x404C47C: getdelim (in /lib/ld-musl-x86_64.so.1) ==208== ==208== 6 bytes in 2 blocks are definitely lost in loss record 591 of 2,994 ==208== at 0x48A97C1: realloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==208== by 0x404C47C: getdelim (in /lib/ld-musl-x86_64.so.1) ==208== by 0x14FA9C: ??? (in /srv/dunstrepo-1708244844/test/test) ==208== ==208== 12 bytes in 4 blocks are definitely lost in loss record 839 of 2,994 ==208== at 0x48A97C1: realloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==208== by 0x404C47C: getdelim (in /lib/ld-musl-x86_64.so.1) ==208== by 0x1564DC: ??? (in /srv/dunstrepo-1708244844/test/test) ==208== ==208== 15 bytes in 5 blocks are definitely lost in loss record 901 of 2,994 ==208== at 0x48A97C1: realloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==208== by 0x404C47C: getdelim (in /lib/ld-musl-x86_64.so.1) ==208== by 0xFFFFFFFE: ??? ==208== ==208== 24 bytes in 8 blocks are definitely lost in loss record 1,480 of 2,994 ==208== at 0x48A97C1: realloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==208== by 0x404C47C: getdelim (in /lib/ld-musl-x86_64.so.1) ==208== by 0x1FFEFFF80F: ??? ==208== ==208== 42 bytes in 14 blocks are definitely lost in loss record 1,941 of 2,994 ==208== at 0x48A97C1: realloc (in /usr/libexec/valgrind/vgpreload_memcheck-amd64-linux.so) ==208== by 0x404C47C: getdelim (in /lib/ld-musl-x86_64.so.1) ==208== by 0x4E15FC8: ??? (in /usr/lib/libglib-2.0.so.0.7600.6) ```
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1284 +/- ##
==========================================
- Coverage 64.53% 64.48% -0.05%
==========================================
Files 48 48
Lines 7914 7918 +4
==========================================
- Hits 5107 5106 -1
- Misses 2807 2812 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
Hopefully the ci works now |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to the introduction of
wordexpin e9a27c0 but did go unnoticed as it seems to be detected just by newer versions of valgrind (I would rule out musl here as thewordexpcode was not touched in ages andgetdelimwas last mentioned in the 1.1.22 version while the old alpine image already shipped 1.1.24).This isn't an issue with the current images but newer versions of alpine fail to complete without it (see this comment).