-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Print compile-time options in dunst --version
#1336
Conversation
Similar to vim features dump, also prints the cflags.
|
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
- Coverage 65.92% 65.88% -0.05%
==========================================
Files 50 50
Lines 8070 8075 +5
Branches 925 925
==========================================
Hits 5320 5320
- Misses 2750 2755 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
This also prevents unneeded dynamic linkage
Makefile
Outdated
debug: all | ||
|
||
-include $(DEPS) | ||
|
||
${OBJ} ${TEST_OBJ}: Makefile config.mk | ||
|
||
src/dunst.o: src/dunst.c | ||
${CC} -o $@ -c $< ${CPPFLAGS} ${CFLAGS} -D_CFLAGS="$(filter-out $(filter -I%,${INCS}),${CFLAGS})" -D_LDFLAGS="${LDFLAGS}" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note: filter out includes to declutter output (the user won't probably care either way)
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1336 +/- ##
==========================================
- Coverage 65.92% 65.88% -0.05%
==========================================
Files 50 50
Lines 8070 8075 +5
Branches 925 925
==========================================
Hits 5320 5320
- Misses 2750 2755 +5
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
In retrospect this should have been added before the release, but better later than never...