Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove default icons and refactor icon-lookup #1365

Merged
merged 3 commits into from
Jul 15, 2024

Conversation

bynect
Copy link
Member

@bynect bynect commented Jul 1, 2024

As requested by #1364 and #1358. I also refactored the search function to provide more informative logging

@bynect bynect requested a review from zappolowski July 1, 2024 13:46
@codecov-commenter
Copy link

codecov-commenter commented Jul 1, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 25.00000% with 27 lines in your changes missing coverage. Please review.

Project coverage is 66.07%. Comparing base (b23a2d3) to head (712fe73).

Files Patch % Lines
src/icon.c 24.24% 25 Missing ⚠️
src/option_parser.c 0.00% 1 Missing ⚠️
src/settings.c 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1365      +/-   ##
==========================================
- Coverage   66.08%   66.07%   -0.01%     
==========================================
  Files          50       50              
  Lines        8247     8228      -19     
  Branches      965      966       +1     
==========================================
- Hits         5450     5437      -13     
+ Misses       2797     2791       -6     
Flag Coverage Δ
unittests 66.07% <25.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect bynect linked an issue Jul 1, 2024 that may be closed by this pull request
@bynect
Copy link
Member Author

bynect commented Jul 1, 2024

some cleanup

@bynect bynect changed the title Remove default icons Remove default icons and refactor icon-lookup Jul 2, 2024
@bynect
Copy link
Member Author

bynect commented Jul 9, 2024

@fwsmit does it looks good? can I merge?

@fwsmit
Copy link
Member

fwsmit commented Jul 14, 2024

@fwsmit does it looks good? can I merge?

Yeah, looks good. You can go ahead and merge

@bynect
Copy link
Member Author

bynect commented Jul 15, 2024

@fwsmit does it looks good? can I merge?

Yeah, looks good. You can go ahead and merge

perfect 👍🏻

@bynect bynect merged commit 5c16b3c into dunst-project:master Jul 15, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

How to disable icons in dunstify
3 participants