-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove default icons and refactor icon-lookup #1365
Conversation
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1365 +/- ##
==========================================
- Coverage 66.08% 66.07% -0.01%
==========================================
Files 50 50
Lines 8247 8228 -19
Branches 965 966 +1
==========================================
- Hits 5450 5437 -13
+ Misses 2797 2791 -6
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
some cleanup |
@fwsmit does it looks good? can I merge? |
Yeah, looks good. You can go ahead and merge |
perfect 👍🏻 |
As requested by #1364 and #1358. I also refactored the search function to provide more informative logging