Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some warnings (gint formatting, size_t/int mix, etc) #1424

Merged
merged 3 commits into from
Jan 2, 2025

Conversation

bynect
Copy link
Member

@bynect bynect commented Dec 27, 2024

Related to #1372

@codecov-commenter
Copy link

codecov-commenter commented Dec 27, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

Attention: Patch coverage is 85.36585% with 18 lines in your changes missing coverage. Please review.

Project coverage is 65.21%. Comparing base (63e6e88) to head (c3e648b).
Report is 2 commits behind head on master.

Files with missing lines Patch % Lines
src/notification.c 0.00% 8 Missing ⚠️
src/rules.c 0.00% 3 Missing ⚠️
src/menu.c 0.00% 2 Missing ⚠️
src/dunst.c 0.00% 1 Missing ⚠️
src/queues.c 93.75% 1 Missing ⚠️
src/settings.c 0.00% 1 Missing ⚠️
src/wayland/wl.c 0.00% 1 Missing ⚠️
src/x11/screen.c 0.00% 1 Missing ⚠️

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1424      +/-   ##
==========================================
+ Coverage   65.17%   65.21%   +0.04%     
==========================================
  Files          50       50              
  Lines        8723     8737      +14     
  Branches     1034     1034              
==========================================
+ Hits         5685     5698      +13     
- Misses       3038     3039       +1     
Flag Coverage Δ
unittests 65.21% <85.36%> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@@ -351,7 +357,7 @@ GdkPixbuf *icon_get_for_data(GVariant *data, char **id, double dpi_scale, int mi
width,
height,
rowstride,
(GdkPixbufDestroyNotify) g_free,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fwsmit I replaced this g_free with an actual function taking two arguments since it just seemed wrong. Was this supposed to free both the pixels and data_pb?

@bynect
Copy link
Member Author

bynect commented Dec 27, 2024

Int formatting was a problem on Openbsd and on x86 architecture. I tried to fix some other warnings like unused param and size_t instead of int

@bynect bynect merged commit 8010c7e into dunst-project:master Jan 2, 2025
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants