Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add env vars to dunstctl history, resolve #1425 #1426

Merged
merged 1 commit into from
Dec 31, 2024

Conversation

BinaryInk
Copy link
Contributor

Thought it may be prudent of me to offer a fix once it occurred to me the fix would probably take less work than the workaround...

Adds the following to dunstctl history JSON output:

  • urgency
  • stack_tag
  • urls

e.g.,

{
                "body" : {
                    "type" : "s",
                    "data" : "Test"
                },
                "message" : {
                    "type" : "s",
                    "data" : "<b>Test</b>\nTest"
                },
                "summary" : {
                    "type" : "s",
                    "data" : "Test"
                },
                "appname" : {
                    "type" : "s",
                    "data" : "TestingtonMcTestles"
                },
                "category" : {
                    "type" : "s",
                    "data" : ""
                },
                "default_action_name" : {
                    "type" : "s",
                    "data" : "default"
                },
                "icon_path" : {
                    "type" : "s",
                    "data" : ""
                },
                "id" : {
                    "type" : "i",
                    "data" : 2
                },
                "timestamp" : {
                    "type" : "x",
                    "data" : 159863270957
                },
                "timeout" : {
                    "type" : "x",
                    "data" : 5000
                },
                "progress" : {
                    "type" : "i",
                    "data" : -1
                },
                "urgency" : {
                    "type" : "s",
                    "data" : "CRITICAL"
                },
                "stack_tag" : {
                    "type" : "s",
                    "data" : ""
                },
                "urls" : {
                    "type" : "s",
                    "data" : ""
                }
            }

@codecov-commenter
Copy link

codecov-commenter commented Dec 30, 2024

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.19%. Comparing base (63e6e88) to head (0643dec).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1426      +/-   ##
==========================================
+ Coverage   65.17%   65.19%   +0.02%     
==========================================
  Files          50       50              
  Lines        8723     8729       +6     
  Branches     1034     1034              
==========================================
+ Hits         5685     5691       +6     
  Misses       3038     3038              
Flag Coverage Δ
unittests 65.19% <100.00%> (+0.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect bynect merged commit b7abe8f into dunst-project:master Dec 31, 2024
23 checks passed
@BinaryInk BinaryInk deleted the BinaryInk/issue1425 branch December 31, 2024 23:12
bynect added a commit that referenced this pull request Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants