Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for additions in #1426 #1431

Merged
merged 3 commits into from
Jan 8, 2025

Conversation

BinaryInk
Copy link
Contributor

Self-explanatory; added three assertions to test for values for the properties urgency, stack_tag, and urls are being outputted via dunstctl history

@codecov-commenter
Copy link

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.32%. Comparing base (8010c7e) to head (7789fbc).

❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #1431      +/-   ##
==========================================
+ Coverage   65.21%   65.32%   +0.10%     
==========================================
  Files          50       50              
  Lines        8737     8763      +26     
  Branches     1034     1034              
==========================================
+ Hits         5698     5724      +26     
  Misses       3039     3039              
Flag Coverage Δ
unittests 65.32% <100.00%> (+0.10%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bynect bynect merged commit 5408dfc into dunst-project:master Jan 8, 2025
23 checks passed
@bynect
Copy link
Member

bynect commented Jan 8, 2025

👍🏻

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants