-
Notifications
You must be signed in to change notification settings - Fork 350
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add freebsd runner #1437
base: master
Are you sure you want to change the base?
Add freebsd runner #1437
Conversation
859fb68
to
d312c85
Compare
since the freebsd is in a vm it takes a very long time to run. I am thinking of making it a manual trigger |
rule_field_matches_string failed because it relied on UB as discussed in dunst-project#1171
14d4907
to
eb01b3f
Compare
the freebsd runner takes 2.30 minutes on average, compared to the 30 seconds for linux distros... anyway, I adapted the code to work with Freebsd using coreutils. we may want to remove gnu specific stuff and stick to posix for more compatibility but for now this is what I could do |
@fwsmit @zappolowski what do you think about this? I think it is a nice addition to check support for bsd. my only concern is the github ci compute times but maybe 2.30 minutes is not too much. ps: I have no clue why the arch ci is failing but it seems unrelated |
Not that knowledgeable on that topic, but the Edit: reference for how it could be done: https://github.com/labwc/labwc/blob/master/.github/workflows/build.yml#L68 |
thanks for the tip! I updated our images and now it works again 👍🏻 |
Codecov ReportAll modified and coverable lines are covered by tests ✅
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## master #1437 +/- ##
==========================================
- Coverage 65.32% 65.31% -0.01%
==========================================
Files 50 50
Lines 8763 8762 -1
Branches 1034 1034
==========================================
- Hits 5724 5723 -1
Misses 3039 3039
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
No description provided.