Fix user.URLValues() to skip pointer values that are empty #56
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…y user.URLValues() would return a []string{} for the pointer struct attributes if empty.
bensallen
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix
user.URLValues()to also skip pointer values that are zero values. Previouslyuser.URLValues()would return a[]string{""}for the pointer struct attributes if empty.Motivation and Context
When the output of
URLValues()was used as input to ModifyUser, for example, the attributes incorrectly set to[]string{""}would result in the user having those values set to""via the Admin API. Resulting in unexpected attribute changes.How Has This Been Tested?
Added additional test case that includes the possible types of zero values, as well as a live test against a Duo instance's Admin API.
Types of Changes