Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

w3sper.js: Add CI #2874

Merged
merged 3 commits into from
Nov 14, 2024
Merged

w3sper.js: Add CI #2874

merged 3 commits into from
Nov 14, 2024

Conversation

Daksh14
Copy link
Contributor

@Daksh14 Daksh14 commented Nov 6, 2024

Compile wallet-core wasm in the CI run docker container and run w3sper tests

Resolves #2255

@Daksh14 Daksh14 force-pushed the w3sper_ci branch 5 times, most recently from b815582 to 82be314 Compare November 6, 2024 07:05
@Daksh14 Daksh14 requested a review from ZER0 November 6, 2024 07:05
@Daksh14
Copy link
Contributor Author

Daksh14 commented Nov 7, 2024

Follow up issue #2891

Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good, few nits about naming and need a refactoring once #2925 is landed (we might land as is and then improve later so we can unblock the CI)

@Daksh14 Daksh14 force-pushed the w3sper_ci branch 3 times, most recently from f87d23e to 80db5f5 Compare November 14, 2024 13:36
@ZER0 ZER0 mentioned this pull request Nov 14, 2024
Copy link
Contributor

@ZER0 ZER0 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Daksh14 Daksh14 merged commit fbc671f into master Nov 14, 2024
15 checks passed
@Daksh14 Daksh14 deleted the w3sper_ci branch November 14, 2024 14:49
@Daksh14 Daksh14 restored the w3sper_ci branch November 14, 2024 16:52
@HDauven HDauven deleted the w3sper_ci branch December 15, 2024 11:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

w3sper: Add CI
2 participants