Skip to content

Conversation

@dustinsgoodman
Copy link
Owner

Closes #106

  • Add serverless-domain-manager
  • Add helper for configuring the settings
  • Show where to add the plugin in public-api

Current Debates:

  • Should this even be included in this template?
  • Is the override too restrictive? See docs for all different config options: https://github.com/amplify-education/serverless-domain-manager#installing
  • Does it need better documentation or examples? For instance, each service could theoretically be deployed to a subdomain but that defeats the purposes of the pattern of a single service for public interaction.

@codecov
Copy link

codecov bot commented Aug 5, 2022

Codecov Report

Merging #248 (397b5d8) into main (6414e86) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #248   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           18        18           
  Lines          117       117           
  Branches        11        11           
=========================================
  Hits           117       117           

Help us with your feedback. Take ten seconds to tell us how you rate us.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Add serverless-domain-manager to public-api service

2 participants