Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Embedding drawing node size #158

Merged
merged 2 commits into from
Mar 3, 2020

Conversation

joseppinilla
Copy link
Contributor

The overlapped_embedding option is hogging the node_size parameter.
This PR allows the user to control it again, if wanted.

@codecov-io
Copy link

codecov-io commented Feb 27, 2020

Codecov Report

Merging #158 into master will increase coverage by 0.02%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #158      +/-   ##
==========================================
+ Coverage   71.89%   71.92%   +0.02%     
==========================================
  Files          26       26              
  Lines        1637     1635       -2     
==========================================
- Hits         1177     1176       -1     
+ Misses        460      459       -1
Impacted Files Coverage Δ
dwave_networkx/drawing/qubit_layout.py 8.13% <0%> (+0.06%) ⬆️
dwave_networkx/algorithms/elimination_ordering.py 86.59% <0%> (-0.35%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 083783b...07888a1. Read the comment docs.

Copy link
Member

@arcondello arcondello left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@arcondello arcondello merged commit df8901e into dwavesystems:master Mar 3, 2020
@arcondello
Copy link
Member

@joseppinilla , do you need a new dnx deploy or are you ok installing from master for now?

@joseppinilla
Copy link
Contributor Author

Installing from master should be OK for now.
Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants