feat(bonsai-ui): migrate markets #1483
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jaredvu
reviewed
Jan 30, 2025
| @@ -88,7 +88,7 @@ export const useTradingView = ({ | |||
| [marketId: string]: number | undefined; | |||
| }>({}); | |||
| const { tickSizeDecimals: tickSizeDecimalsAbacus } = orEmptyObj( | |||
| useAppSelector(getCurrentMarketConfig) | |||
| useAppSelector(BonsaiHelpers.currentMarket.stableMarketInfo) | |||
There was a problem hiding this comment.
This is a weird hook. It is expecting indexer tickSizeDecimals as well as Abacus ones. I understand replacing the tickSizeDecimalsAbacus but maybe we can deprecate needing a fallback here
There was a problem hiding this comment.
oh yeah what is happening here. Why would it load the tick size manually from the indexer instead of waiting for abacus to load it????? huuuh
jaredvu
approved these changes
Jan 30, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.