Support for larger phabricator instances where more than 100 projects exist #110
Conversation
added handling of over 100 projects/tags
Update maniphest.py
Update maniphest.py
Timpan4
left a comment
Timpan4
left a comment
There was a problem hiding this comment.
Thank you for your PR!
Overall the feature implementation looks good. Just some small suggestions.
Could you also rebase and fix the merge conflicts before approval?
| ```Commnad prompt | ||
| echo "PHAB_TOKEN: cli-ABC123" > %LOCALAPPDATA%\phabfive\phabfive.yaml | ||
| ``` | ||
|
|
||
| **Environment variables:** | ||
| ```bash | ||
| export PHAB_TOKEN=cli-ABC123 | ||
| export PHAB_URL=https://yourserver.com/api/ | ||
| Additionally, due to connection to Phabricator server on HTTPS requires certificate verification, it is also recommended to install [pip_system_certs](https://pypi.org/project/pip-system-certs/) to ensure system store are linked to python. | ||
|
|
||
| ```Commnad prompt | ||
| pip install pip_system_certs | ||
| ``` |
There was a problem hiding this comment.
Please change the codeblock type to shell and the pip install command to uv pip install
There was a problem hiding this comment.
hi, as this is windows specific, should I change to shell?
There was a problem hiding this comment.
The Windows specific ones for the CMD "Command Prompt" would be batch, but I would set this particular one to shell and the two above (with %SOMEVAR%) to batch as they reference variables in the CMD syntax.
It would however be best to convert the Windows examples to Powershell and use powershell instead.
phabfive/maniphest.py
Outdated
| # Extended support for phabricator instances with more than 100 (i.e. deftault query limit) users | ||
| # BUT with limieted exception handling e.g. retries needed when phabricator instance is not responding to API calls |
There was a problem hiding this comment.
These comments could be removed. They only serve a purpose for the reviewer of this PR
phabfive/maniphest.py
Outdated
| # Extended support for phabricator instances with more than 100 (i.e. deftault query limit) projects | ||
| # BUT with limieted exception handling, e.g. retries needed when phabricator instance is not responding to API calls |
There was a problem hiding this comment.
These comments could be removed. They only serve a purpose for the reviewer of this PR
Removed comments regarding extended support for fetching users and projects from Phabricator.
3 participants
Fixes: