Skip to content

Bugfix: simulation_type_knockdown with multiple genes #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Bugfix: simulation_type_knockdown with multiple genes #57

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
5cb65f6
Bugfix, make it easier to generate knockdown simulations involving mu…
LouiseDck Feb 21, 2024
b335209
Change setup-r to v2
LouiseDck Feb 21, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions .github/workflows/R-CMD-check.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,19 +31,19 @@ jobs:
steps:
- uses: actions/checkout@v2

- uses: r-lib/actions/setup-pandoc@v1
- uses: r-lib/actions/setup-pandoc@v2

- uses: r-lib/actions/setup-r@v1
- uses: r-lib/actions/setup-r@v2
with:
r-version: ${{ matrix.config.r }}
http-user-agent: ${{ matrix.config.http-user-agent }}
use-public-rspm: true

- uses: r-lib/actions/setup-r-dependencies@v1
- uses: r-lib/actions/setup-r-dependencies@v2
with:
extra-packages: rcmdcheck

- uses: r-lib/actions/check-r-package@v1
- uses: r-lib/actions/check-r-package@v2

- name: Show testthat output
if: always()
Expand Down
4 changes: 4 additions & 0 deletions NEWS.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
# dyngen 1.0.6

* BUG FIX `simulation_type_knockdown()`: Allow easier knocking down of multiple genes.

# dyngen 1.0.5

* MINOR CHANGE: Refactor matrix coercion thanks to Matrix 1.5-0.
Expand Down
2 changes: 1 addition & 1 deletion R/6_simulation.R
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -617,7 +617,7 @@ simulation_type_knockdown <- function(
(is.list(genes) && length(genes) == num_simulations) ||
is.character(genes) || is.factor(genes)
)
if (!is.list(genes)) genes <- as.list(rep(genes, num_simulations))
if (!is.list(genes)) genes <- as.list(rep(list(genes), num_simulations))

tibble(
type = "knockdown",
Expand Down