test fix and cache module patches #23
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi David,
I fixed a test case (believe it was a regression due to the os.path.realpath commit), and also pulled the CACHE_BACKEND feature from django_compressor (with test), and would love to have these included so I don't have to keep this fork.
The cache backend feature is essential for my use case because I'd like the default Django cache backend to use a shared cache of multiple memcached instances, but when running Django on multiple machines, django-css will find that the compressed file path is already in cache (placed by another Django instance on a different machine) and it won't bother to generated the media file locally causing a 404. Obviously this can be solved by some sort of NFS or using a storage backend that is distributed, but we intentionally do not want that.
Let me know if you have any questions or concerns.
.wil